pan3793 commented on code in PR #2045:
URL:
https://github.com/apache/incubator-celeborn/pull/2045#discussion_r1378553957
##########
common/src/main/java/org/apache/celeborn/common/protocol/StorageInfo.java:
##########
@@ -23,10 +23,13 @@
public class StorageInfo implements Serializable {
public enum Type {
MEMORY(0),
+ @Deprecated
HDD(1),
+ @Deprecated
Review Comment:
From the user aspect, I'd like to keep HDD and SSD, because it's already
used and easy to be accepted by users, such breaking change does not bring many
benefits.
Also, MEMORY, LOCAL, OSS, HDFS is not ideal too, OSS/HDFS should be
clustered into REMOTE, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
