RexXiong commented on code in PR #2045:
URL:
https://github.com/apache/incubator-celeborn/pull/2045#discussion_r1381293871
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -400,7 +400,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
}
hdfsWriters.put(fileInfo.getFilePath, hdfsWriter)
return hdfsWriter
- } else {
+ } else if (location.getStorageInfo.localDiskAvailable()) {
Review Comment:
!dirs.isEmpty && location.getStorageInfo.localDiskAvailable()
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/worker/storage/WorkerSuite.scala:
##########
@@ -30,7 +30,7 @@ import org.scalatest.funsuite.AnyFunSuite
import org.apache.celeborn.common.CelebornConf
import org.apache.celeborn.common.identity.UserIdentifier
-import org.apache.celeborn.common.protocol.{PartitionLocation,
PartitionSplitMode, PartitionType}
+import org.apache.celeborn.common.protocol.{PartitionLocation,
PartitionSplitMode, PartitionType, StorageInfo}
Review Comment:
useless import StorageInfo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
