kerwin-zk commented on code in PR #2070:
URL:
https://github.com/apache/incubator-celeborn/pull/2070#discussion_r1382905884
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -315,21 +328,13 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
// If shuffle is registered, reply this shuffle's partition location
and return.
// Else add this request to registeringShuffleRequest.
if (registeredShuffle.contains(shuffleId)) {
- val initialLocs = workerSnapshots(shuffleId)
- .values()
- .asScala
- .flatMap(_.getAllPrimaryLocationsWithMinEpoch())
- .filter(p =>
- (partitionType == PartitionType.REDUCE && p.getEpoch == 0) ||
(partitionType == PartitionType.MAP && p.getId == partitionId))
- .toArray
partitionType match {
case PartitionType.MAP => processMapTaskReply(
shuffleId,
context.context,
- partitionId,
- initialLocs)
+ partitionId)
case PartitionType.REDUCE =>
- context.reply(RegisterShuffleResponse(StatusCode.SUCCESS,
initialLocs))
+ processResponseWithCache(context.context)
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
