mridulm commented on code in PR #2070:
URL:
https://github.com/apache/incubator-celeborn/pull/2070#discussion_r1384414179
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -344,6 +368,14 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
}
}
+ def getInitialLocs(shuffleId: Int): Array[PartitionLocation] = {
Review Comment:
nit: We return an array which is almost always resized to a much smaller
size due to a suffix filter.
Do we want to pass that filter here ? Or return a Seq which is then
converted to `toArray` after the filter is applied ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
