FMX commented on code in PR #2088: URL: https://github.com/apache/incubator-celeborn/pull/2088#discussion_r1390706992
########## common/src/main/java/org/apache/celeborn/common/meta/MemoryBuffers.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.meta; + +import java.util.List; + +import io.netty.buffer.ByteBuf; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.celeborn.common.network.buffer.ManagedBuffer; +import org.apache.celeborn.common.network.buffer.NettyManagedBuffer; +import org.apache.celeborn.common.network.util.TransportConf; +import org.apache.celeborn.common.util.MemCacheManager; + +public class MemoryBuffers implements Buffers { Review Comment: This class can be merged into FileManagedBuffers. These codes look quite similar. ########## common/src/main/java/org/apache/celeborn/common/meta/Buffers.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.meta; + +import org.apache.celeborn.common.network.buffer.ManagedBuffer; + +public interface Buffers { Review Comment: Unnecessary ########## common/src/main/java/org/apache/celeborn/common/util/MemCacheManager.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.util; + +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; +import java.util.concurrent.atomic.AtomicLong; + +import io.netty.buffer.ByteBuf; + +import org.apache.celeborn.common.CelebornConf; + +public class MemCacheManager { Review Comment: This class can be merged into memory manager. ########## common/src/main/java/org/apache/celeborn/common/meta/FileManagedBuffers.java: ########## @@ -24,7 +24,8 @@ import org.apache.celeborn.common.network.buffer.ManagedBuffer; import org.apache.celeborn.common.network.util.TransportConf; -public class FileManagedBuffers { +public class FileManagedBuffers implements Buffers { Review Comment: Making this class able to read shuffle files and shuffle memory cache will make code more readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
