waitinfuture commented on code in PR #2088:
URL:
https://github.com/apache/incubator-celeborn/pull/2088#discussion_r1390729177
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -637,6 +639,12 @@ private void initializeFiles() throws IOException {
hdfsSortedOutput =
StorageManager.hadoopFs().create(new Path(sortedFilePath), true,
256 * 1024);
} else {
+ if (memCacheManager.contains(originFilePath)) {
+ FileChannel channel =
FileChannelUtils.createWritableFileChannel(originFilePath);
+ channel.write(memCacheManager.getCache(originFilePath).nioBuffer());
Review Comment:
IMO supporting sort in memory cache is out of this PR's scope, I think this
is ok to fallback to disk-based when sort happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
