cfmcgrady commented on code in PR #2061:
URL:
https://github.com/apache/incubator-celeborn/pull/2061#discussion_r1407681240
##########
dev/dependencies.sh:
##########
@@ -56,9 +56,9 @@ function mvn_build_classpath() {
}
function sbt_build_client_classpath() {
- PATTERN="$SBT_PROJECT / Runtime / externalDependencyClasspath"
+ PATTERN="$SBT_PROJECT / Runtime / managedClasspath"
Review Comment:
From SBT docs
[externalDependencyClasspath](https://github.com/sbt/sbt/blob/edc10297b0977e3b099f37b8363b33b404bc43c3/main/src/main/scala/sbt/Keys.scala#L366)
> The classpath consisting of library dependencies, both managed and
unmanaged.
[managedClasspath](https://github.com/sbt/sbt/blob/edc10297b0977e3b099f37b8363b33b404bc43c3/main/src/main/scala/sbt/Keys.scala#L364)
> The classpath consisting of external, managed library dependencies.
Can you explain more about why we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
