SteNicholas commented on code in PR #2061:
URL:
https://github.com/apache/incubator-celeborn/pull/2061#discussion_r1407686214
##########
dev/dependencies.sh:
##########
@@ -56,9 +56,9 @@ function mvn_build_classpath() {
}
function sbt_build_client_classpath() {
- PATTERN="$SBT_PROJECT / Runtime / externalDependencyClasspath"
+ PATTERN="$SBT_PROJECT / Runtime / managedClasspath"
Review Comment:
@cfmcgrady, I have introduced `JDKTools` to add `tool.jar` into
`unmanagedJars`, which causes that the path of `tool.jar` is relative.
Meanwhile, the maven dependencies are all added into `managedJars`, therefore
we could only check the managed classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
