SteNicholas commented on code in PR #2120:
URL:
https://github.com/apache/incubator-celeborn/pull/2120#discussion_r1408711134
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -84,9 +89,11 @@ private static class ClientPool {
private EventLoopGroup workerGroup;
protected ByteBufAllocator pooledAllocator;
- public TransportClientFactory(TransportContext context) {
+ public TransportClientFactory(
+ TransportContext context, List<TransportClientBootstrap>
clientBootstraps) {
this.context = Preconditions.checkNotNull(context);
TransportConf conf = context.getConf();
+ this.clientBootstraps =
Lists.newArrayList(Preconditions.checkNotNull(clientBootstraps));
Review Comment:
```suggestion
this.clientBootstraps = Preconditions.checkNotNull(clientBootstraps);
```
Could this update to above? IMO, this does not need to use
`Lists.newArrayList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
