otterc commented on code in PR #2120:
URL:
https://github.com/apache/incubator-celeborn/pull/2120#discussion_r1408893599
##########
common/src/main/java/org/apache/celeborn/common/network/TransportContext.java:
##########
@@ -93,35 +97,60 @@ public TransportContext(TransportConf conf,
BaseMessageHandler msgHandler) {
this(conf, msgHandler, false, false, null);
}
+ public TransportClientFactory
createClientFactory(List<TransportClientBootstrap> bootstraps) {
+ return new TransportClientFactory(this, bootstraps);
+ }
+
public TransportClientFactory createClientFactory() {
- return new TransportClientFactory(this);
+ return createClientFactory(Collections.emptyList());
}
/** Create a server which will attempt to bind to a specific host and port.
*/
public TransportServer createServer(String host, int port) {
- return new TransportServer(this, host, port, source);
+ return new TransportServer(this, host, port, source, msgHandler,
Collections.emptyList());
+ }
+
+ public TransportServer createServer(
Review Comment:
Removed the methods which were not being used now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
