suizhe007 commented on code in PR #2089:
URL:
https://github.com/apache/incubator-celeborn/pull/2089#discussion_r1410288229
##########
service/src/main/scala/org/apache/celeborn/server/common/http/HttpRequestHandler.scala:
##########
@@ -49,8 +49,14 @@ class HttpRequestHandler(
val msg = HttpUtils.handleRequest(service, path, parameters)
val response = msg match {
case Invalid.invalid =>
- if (prometheusHttpRequestHandler != null) {
- prometheusHttpRequestHandler.handleRequest(uri)
+ if (servletHttpRequestHandlers != null) {
+ val servletHttpRequestHandler =
servletHttpRequestHandlers.find(servlet =>
+ uri == servlet.getServletPath())
+ if (servletHttpRequestHandler.nonEmpty) {
+ servletHttpRequestHandler.get.handleRequest(uri)
Review Comment:
> should we update it for JSON?
>
> ```
> res.headers().set(HttpHeaderNames.CONTENT_TYPE, "text/plain;
charset=UTF-8")
> ```
Thank you. You are right. I update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
