cfmcgrady commented on code in PR #2089:
URL:
https://github.com/apache/incubator-celeborn/pull/2089#discussion_r1411608435
##########
common/src/main/scala/org/apache/celeborn/common/metrics/MetricsSystem.scala:
##########
@@ -27,30 +27,34 @@ import scala.util.matching.Regex
import com.codahale.metrics.{Metric, MetricFilter, MetricRegistry}
import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.CelebornConf.{METRICS_JSON_PATH,
METRICS_PROMETHEUS_PATH}
import org.apache.celeborn.common.internal.Logging
-import org.apache.celeborn.common.metrics.sink.{PrometheusHttpRequestHandler,
PrometheusServlet, Sink}
+import org.apache.celeborn.common.metrics.sink.{JsonServlet,
PrometheusServlet, ServletHttpRequestHandler, Sink}
import org.apache.celeborn.common.metrics.source.Source
import org.apache.celeborn.common.util.Utils
class MetricsSystem(
val instance: String,
- conf: CelebornConf,
- val servletPath: String) extends Logging {
+ conf: CelebornConf) extends Logging {
private[this] val metricsConfig = new MetricsConfig(conf)
private val sinks = new ArrayBuffer[Sink]
private val sources = new CopyOnWriteArrayList[Source]
private val registry = new MetricRegistry()
+ val prometheusServletPath = conf.get(METRICS_PROMETHEUS_PATH)
+ val jsonServletPath = conf.get(METRICS_JSON_PATH)
Review Comment:
```suggestion
private val prometheusServletPath = conf.get(METRICS_PROMETHEUS_PATH)
private val jsonServletPath = conf.get(METRICS_JSON_PATH)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
