pan3793 commented on code in PR #2125:
URL:
https://github.com/apache/incubator-celeborn/pull/2125#discussion_r1411690188
##########
docs/configuration/worker.md:
##########
@@ -19,8 +19,8 @@ license: |
<!--begin-include-->
| Key | Default | Description | Since |
| --- | ------- | ----------- | ----- |
-| celeborn.dynamicConfig.refresh.time | 120s | The time interval for
refreshing the corresponding dynamic config periodically | 0.4.0 |
-| celeborn.dynamicConfig.store.backend | NONE | Store backend for dynamic
config, NONE means disabling dynamic config store | 0.4.0 |
+| celeborn.dynamicConfig.refresh.time | 120s | The time interval for
refreshing the corresponding dynamic config periodically. | 0.4.0 |
Review Comment:
I would prefer to call it `celeborn.dynamicConfig.refresh.interval`
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java:
##########
@@ -30,19 +28,21 @@
import java.util.concurrent.atomic.AtomicReference;
import java.util.stream.Collectors;
+import scala.concurrent.duration.Duration;
Review Comment:
Emm... seems we should use Java Duration given Celeborn is a Java & Scala
mixed project
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java:
##########
@@ -17,7 +17,7 @@
package org.apache.celeborn.server.common.service.config;
-public interface ConfigService {
+public interface ConfigService extends AutoCloseable {
Review Comment:
looks unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
