RexXiong commented on code in PR #2125:
URL:
https://github.com/apache/incubator-celeborn/pull/2125#discussion_r1413551890
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java:
##########
@@ -88,10 +85,12 @@ private synchronized void refresh() {
}
} catch (Exception e) {
LOG.warn("Refresh dynamic config error: {}", e.getMessage(), e);
+ return;
Review Comment:
I rethought that this change might cause systemConf to be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
