mridulm commented on code in PR #2123:
URL:
https://github.com/apache/incubator-celeborn/pull/2123#discussion_r1412722880
##########
common/src/test/java/org/apache/celeborn/common/network/RpcIntegrationSuiteJ.java:
##########
@@ -60,32 +58,21 @@ public static void setUp() throws Exception {
new BaseMessageHandler() {
@Override
public void receive(TransportClient client, RequestMessage message) {
- if (message instanceof RpcRequest) {
- String msg;
- RpcRequest r = (RpcRequest) message;
- RpcResponseCallback callback =
- new RpcResponseCallback() {
- @Override
- public void onSuccess(ByteBuffer response) {
- client
- .getChannel()
- .writeAndFlush(
- new RpcResponse(r.requestId, new
NioManagedBuffer(response)));
- }
-
- @Override
- public void onFailure(Throwable e) {
- client
- .getChannel()
- .writeAndFlush(
- new RpcFailure(r.requestId,
Throwables.getStackTraceAsString(e)));
- }
- };
- try {
- msg = JavaUtils.bytesToString(message.body().nioByteBuffer());
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
+ assert message instanceof OneWayMessage;
Review Comment:
Celeborn using junit Assert api in tests ... instead of java assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
