otterc commented on code in PR #2123:
URL:
https://github.com/apache/incubator-celeborn/pull/2123#discussion_r1412726462
##########
common/src/main/java/org/apache/celeborn/common/network/server/BaseMessageHandler.java:
##########
@@ -27,6 +28,10 @@ public void receive(TransportClient client, RequestMessage
msg) {
throw new UnsupportedOperationException();
}
+ public void receive(TransportClient client, RequestMessage msg,
RpcResponseCallback callback) {
Review Comment:
It is not getting ignored. I have made changes to the extensions -
`NettyRpcHandler` to use it. We will use it in `SaslRpcHandler` as well. Draft
PR: https://github.com/apache/incubator-celeborn/pull/2105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
