pan3793 commented on code in PR #2193: URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437996177
########## LICENSE: ########## @@ -210,4 +210,38 @@ for text of these licenses. Apache License 2.0 -------------------------------------- -common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java +Apache Spark +./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java + +Apache Kyuubi +./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java +./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java +./common/src/main/java/org/apache/celeborn/reflect/DynFields.java +./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java +./dev/checkout_pr.sh Review Comment: AFAIK, the `Dyn*` classes originated from the Apache Parquet project, then were borrowed by Apache Iceberg, Apache Kyuubi, and I copied them to Apache Celeborn (incubating). Specifically, I copied a modified version of the Kyuubi project. How should I write the NOTICE or LICENSE is correct then? I had thought that copying code across ASF projects did not require listing files under LICENSE, because, legally speaking, the copyright owner of the code is ASF, not some natural persons. > I think this is redundant, the author of the file belongs to the same person. Sorry, I don't know such a rule. Could you clarify where I can find such guidance that clearly states that the same author could legally contribute the same code to different projects without declarations, even though the copyright of the code belongs to different organizations or companies? Let's say Tom contributes some code to a project under the GPL license, and the copyright owner is company A. Could Tom legally contribute the same code to an ASF project, without any declarations? I think all code contributed to the ASF projects belongs to ASF, there is no difference between different contributors. TBH, different people have different interpretations of LICENSE rules, I believe that I and other community members always respond positively when someone, especially someone we consider to be an expert in the field, adapts to the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
