pan3793 commented on code in PR #2193: URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438001796
########## LICENSE: ########## @@ -210,4 +210,38 @@ for text of these licenses. Apache License 2.0 -------------------------------------- -common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java +Apache Spark +./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java +./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java + +Apache Kyuubi +./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java +./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java +./common/src/main/java/org/apache/celeborn/reflect/DynFields.java +./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java +./dev/checkout_pr.sh Review Comment: @justinmclean thanks for your clarification. In the past, when borrowing code from external projects(non-ASF projects) to an ASF project, I would carefully evaluate the LICENSE and list the copied files under LICENSE and NOTICE. In the future, I will follow your guidance to list files copied from ASF projects too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
