zwangsheng commented on code in PR #2234:
URL:
https://github.com/apache/incubator-celeborn/pull/2234#discussion_r1456721247
##########
web/ui/README.md:
##########
Review Comment:
We should add `pnpm format` command here to tell users how to format.
##########
web/ui/package.json:
##########
@@ -0,0 +1,41 @@
+{
+ "name": "ui",
Review Comment:
naming as `celeborn ui`
##########
web/ui/package.json:
##########
@@ -0,0 +1,41 @@
+{
+ "name": "ui",
+ "version": "0.0.0",
Review Comment:
IMO, we should keep the whole project with same version, so we should fill
this with `0.5.0-SNAPSHOT`. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
