SteNicholas commented on code in PR #2234: URL: https://github.com/apache/incubator-celeborn/pull/2234#discussion_r1456751408
########## web/ui/.gitignore: ########## @@ -0,0 +1,34 @@ +# Logs +logs +*.log +npm-debug.log* +yarn-debug.log* +yarn-error.log* +pnpm-debug.log* +lerna-debug.log* + +node_modules Review Comment: Add the comment for `# dependencies`. ########## web/ui/README.md: ########## @@ -0,0 +1,27 @@ +# ui + +This is the web ui page for Apache Celeborn. Review Comment: ```suggestion > **⚠️ Important** > > Before running commands, you must ensure that you are in the front-end directory `incubator-celeborn/web`. If not, run `cd web` first. --- ``` ########## web/ui/.gitignore: ########## @@ -0,0 +1,34 @@ +# Logs +logs +*.log +npm-debug.log* +yarn-debug.log* Review Comment: @RexXiong, `yarn-debug.log*` and `yarn-error.log*` are always ignored. Refers to [.gitignore](https://github.com/datastrato/gravitino/blob/main/web/.gitignore). ########## web/ui/src/router/modules/overview.ts: ########## @@ -0,0 +1,32 @@ +/* Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. */ + +export default { + path: '/home', + name: 'home', + meta: { title: 'Home' }, + redirect: { name: 'overview' }, + sub: false, + children: [ + { + path: '/overview', + name: 'overview', + meta: { title: 'overview' }, + component: () => import('@/views/HomePage.vue') Review Comment: Could `HomePage.Vue` rename to `Overview.vue`? ########## web/ui/README.md: ########## @@ -0,0 +1,27 @@ +# ui + +This is the web ui page for Apache Celeborn. + +## Project Setup Review Comment: ```suggestion ## Getting started ### Preparation | Framework & Dependencies - [Vue](https://vuejs.org) > **TIP** > > You should use the Pnpm package manager. > ## Installation ### Development environment - Run the below command in the console to install the required dependencies. ``` ########## web/ui/index.html: ########## @@ -0,0 +1,30 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> + +<!DOCTYPE html> +<html lang="en"> + <head> + <meta charset="UTF-8"> + <link rel="icon" href="/favicon.ico"> + <meta name="viewport" content="width=device-width, initial-scale=1.0"> + <title>Apache Celeborn Web</title> Review Comment: ```suggestion <title>Apache Celeborn</title> ``` ########## web/ui/README.md: ########## @@ -0,0 +1,27 @@ +# ui Review Comment: ```suggestion # Celeborn Web UI ``` ########## web/ui/.eslintrc.cjs: ########## @@ -0,0 +1,32 @@ +/* Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. */ + +/* eslint-env node */ +require('@rushstack/eslint-patch/modern-module-resolution') Review Comment: Please rename `ui` directory to `app`. ########## web/ui/src/router/routes.ts: ########## @@ -0,0 +1,34 @@ +/* Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. */ + +import overview_routes from './modules/overview' + +export const basePage = [ + { + path: '/', + redirect: '/home', + sub: true, + component: () => import('@/layouts/layoutPage.vue'), Review Comment: Could `layoutPage.vue` rename to `Layout.vue`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
