SteNicholas commented on code in PR #2346:
URL:
https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1508418112
##########
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala:
##########
@@ -446,9 +447,24 @@ object PbSerDeUtils {
builder.setCurrentAppDiskUsageMetricsSnapshot(
toPbAppDiskUsageSnapshot(currentAppDiskUsageMetricsSnapshot))
}
+ if (applicationMetas != null) {
Review Comment:
```suggestion
if (CollectionUtils.isNotEmpty(applicationMetas)) {
```
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/MasterSecretRegistryImpl.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.celeborn.common.network.sasl.SecretRegistry;
+import org.apache.celeborn.common.network.sasl.SecretRegistryImpl;
+import org.apache.celeborn.service.deploy.master.clustermeta.IMetadataHandler;
+
+/**
+ * A simple implementation of {@link SecretRegistry} that stores secrets in
memory and Ratis. This
+ * persists an application secret in Ratis but the deletion of that secret
happens when
+ * ApplicationLost is triggered.
+ */
+public class MasterSecretRegistryImpl extends SecretRegistryImpl {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(MasterSecretRegistryImpl.class);
+ private IMetadataHandler metadataHandler;
+
+ @Override
+ public void register(String appId, String secret) {
+ super.register(appId, secret);
+ if (metadataHandler != null) {
+ LOG.info("Persisting metadata for appId: {}", appId);
Review Comment:
```suggestion
LOG.info("Persisting application metadata for {} and {}.", appId,
secret);
```
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/InternalRpcEndpoint.scala:
##########
@@ -28,16 +29,19 @@ import org.apache.celeborn.common.rpc._
*/
private[celeborn] class InternalRpcEndpoint(
override val rpcEnv: RpcEnv,
- val conf: CelebornConf)
+ val conf: CelebornConf,
+ val secretRegistry: SecretRegistry)
extends RpcEndpoint with Logging {
override def onDisconnected(address: RpcAddress): Unit = {
logDebug(s"Client $address got disconnected.")
}
override def receive: PartialFunction[Any, Unit] = {
- // TODO: [CELEBORN-1234] Handle the application secret from the Master
- case _ => throw new CelebornException(self + " not implemented")
+ case pb: PbApplicationMeta =>
+ val appId = pb.getAppId
+ val secret = pb.getSecret
+ logInfo(s"Received application meta for $appId from the coordinator")
Review Comment:
```suggestion
logInfo(s"Received application meta for $appId and $secret from the
coordinator")
```
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -98,6 +98,7 @@ enum MessageType {
REGISTER_APPLICATION_RESPONSE = 75;
WORKER_EVENT_REQUEST = 76;
WORKER_EVENT_RESPONSE = 77;
+ APPLICATION_META = 78;
Review Comment:
```suggestion
SAVE_APPLICATION_META = 78;
```
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/IMetadataHandler.java:
##########
@@ -82,4 +82,6 @@ void handleWorkerEvent(
int workerEventTypeValue, List<WorkerInfo> workerInfoList, String
requestId);
void handleUpdatePartitionSize();
+
+ void handleApplicationMeta(String appId, String secret);
Review Comment:
Could we introduce `ApplicationMeta` to consturct metadata of application
including appId, secret, and user identifer in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
