otterc commented on code in PR #2346:
URL:
https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1508449745
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/IMetadataHandler.java:
##########
@@ -82,4 +82,6 @@ void handleWorkerEvent(
int workerEventTypeValue, List<WorkerInfo> workerInfoList, String
requestId);
void handleUpdatePartitionSize();
+
+ void handleApplicationMeta(String appId, String secret);
Review Comment:
Sure. I made this interface generic. It accepts `ApplicationMeta` now.
##########
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala:
##########
@@ -446,9 +447,24 @@ object PbSerDeUtils {
builder.setCurrentAppDiskUsageMetricsSnapshot(
toPbAppDiskUsageSnapshot(currentAppDiskUsageMetricsSnapshot))
}
+ if (applicationMetas != null) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
