SteNicholas commented on code in PR #2348:
URL:
https://github.com/apache/incubator-celeborn/pull/2348#discussion_r1512088191
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -32,6 +32,19 @@ import org.apache.celeborn.service.deploy.MiniClusterFeature
trait SparkTestBase extends AnyFunSuite
with Logging with MiniClusterFeature with BeforeAndAfterAll with
BeforeAndAfterEach {
+
+ val sparkConf = new
SparkConf().setAppName("rss-demo").setMaster("local[2,3]")
+ val sparkSession = SparkSession.builder().config(sparkConf).getOrCreate()
+ val version =
+ try {
+ sparkSession.sql("select version()").collect()(0).getString(0)
+ } catch {
+ case _: Exception => ""
+ }
+ sparkSession.close()
+ val Spark3OrNewer = version >= "3.0"
Review Comment:
Why not directly use `SparkVersionUtil#isGreaterThan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
