pan3793 commented on code in PR #2348:
URL: 
https://github.com/apache/incubator-celeborn/pull/2348#discussion_r1512163119


##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -32,6 +33,10 @@ import org.apache.celeborn.service.deploy.MiniClusterFeature
 
 trait SparkTestBase extends AnyFunSuite
   with Logging with MiniClusterFeature with BeforeAndAfterAll with 
BeforeAndAfterEach {
+
+  val Spark3OrNewer = SPARK_VERSION >= "3.0"

Review Comment:
   not a big deal, in some case, SPARK_VERSION returns "unknown", and 
   ```
   scala> "unknown" >= "3.0"
   res0: Boolean = true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to