FMX commented on code in PR #2346: URL: https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1512093022
########## common/src/main/scala/org/apache/celeborn/common/util/ApplicationMeta.scala: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.util; + +/** + * Application meta + */ +case class ApplicationMeta(appId: String, secret: String) Review Comment: @otterc I think this class is not a utility. Move it to `org.apache.celeborn.common.meta` will be better. ########## master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java: ########## @@ -84,6 +85,9 @@ public abstract class AbstractMetaManager implements IMetadataHandler { public final LongAdder partitionTotalFileCount = new LongAdder(); public AppDiskUsageMetric appDiskUsageMetric = null; + public final ConcurrentHashMap<String, ApplicationMeta> applicationMetas = Review Comment: The value type of this map can be tuple. ########## common/src/main/scala/org/apache/celeborn/common/util/ApplicationMeta.scala: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.util; + +/** + * Application meta + */ +case class ApplicationMeta(appId: String, secret: String) Review Comment: I think this class defination is unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
