mridulm commented on code in PR #2346:
URL:
https://github.com/apache/incubator-celeborn/pull/2346#discussion_r1515708826
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -253,11 +254,24 @@ private[celeborn] class Master(
internalRpcEndpoint)
}
+ private val sendApplicationMetaThreads =
conf.masterSendApplicationMetaThreads
+ // Send ApplicationMeta to workers
+ private var sendApplicationMetaExecutor: ExecutorService = _
+ // Maintains the mapping for the workers assigned to each application
+ private val workersAssignedToApp
Review Comment:
Good point, we should throw an exception in `SecretRegistryImpl` only if the
values dont match via equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
