RexXiong commented on code in PR #2356:
URL:
https://github.com/apache/incubator-celeborn/pull/2356#discussion_r1515425244
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/CreditStreamManager.java:
##########
@@ -252,6 +251,16 @@ public int getActiveMapPartitionCount() {
return activeMapPartitions.size();
}
+ public void cleanupExpiredShuffleKey(Set<String> expiredShuffleKeys) {
Review Comment:
This change could significantly delay the cleanup time of stream-related
objects, as for Flink shuffle cleanup only occurs when app ends. This may
result in a large streamState objects in memory. I suggest that the related app
metrics can be recorded and cleaned up within StreamState.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
