RexXiong commented on code in PR #2356:
URL:
https://github.com/apache/incubator-celeborn/pull/2356#discussion_r1515773928
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -370,20 +370,26 @@ class FetchHandler(
getRawDiskFileInfo(shuffleKey, fileName).closeStream(
streamId)
case StreamType.CreditStream =>
- workerSource.recordAppActiveConnection(
- client,
- creditStreamManager.getStreamShuffleKey(streamId))
- creditStreamManager.notifyStreamEndByClient(streamId)
+ // Ignore handling BufferStreamEnd after recycling stream of
CreditStreamManager.
Review Comment:
```suggestion
// Ignore handling BufferStreamEnd after recycling stream of
CreditStreamManager.
val shuffleKey = creditStreamManager.getStreamShuffleKey(streamId)
if (shuffleKey!=null) {
workerSource.recordAppActiveConnection(client, shuffleKey)
creditStreamManager.notifyStreamEndByClient(streamId)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
