SteNicholas commented on code in PR #2363:
URL:
https://github.com/apache/incubator-celeborn/pull/2363#discussion_r1516060418
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4632,4 +4634,12 @@ object CelebornConf extends Logging {
.version("0.5.0")
.intConf
.createWithDefault(8)
+
+ val WORKER_APPLICATION_REGISTRY_CACHE_SIZE: ConfigEntry[Int] =
+ buildConf("celeborn.worker.applicationRegistryCache.size")
Review Comment:
```suggestion
buildConf("celeborn.worker.applicationRegistry.cache.size")
```
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -1099,6 +1103,26 @@ private[celeborn] class Master(
}.asJava
}
+ private def handleRequestForApplicationMeta(
+ context: RpcCallContext,
+ pb: PbApplicationMetaRequest): Unit = {
+ val appId = pb.getAppId
+ logDebug(
+ s"Handling request for application meta info $appId.")
+ if (!secretRegistry.isRegistered(appId)) {
+ logWarning(s"Couldn't find the app .")
Review Comment:
```suggestion
logWarning(s"Could not find the application meta of $appId.")
```
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4632,4 +4634,12 @@ object CelebornConf extends Logging {
.version("0.5.0")
.intConf
.createWithDefault(8)
+
+ val WORKER_APPLICATION_REGISTRY_CACHE_SIZE: ConfigEntry[Int] =
+ buildConf("celeborn.worker.applicationRegistryCache.size")
+ .categories("worker", "auth")
+ .doc("Cache size of the application registry on Workers.")
+ .version("0.5.0")
+ .intConf
+ .createWithDefault(10000)
Review Comment:
Why does the default value of cache size is 10000?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
