otterc commented on code in PR #2363:
URL:
https://github.com/apache/incubator-celeborn/pull/2363#discussion_r1516811504
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -1099,6 +1103,26 @@ private[celeborn] class Master(
}.asJava
}
+ private def handleRequestForApplicationMeta(
+ context: RpcCallContext,
+ pb: PbApplicationMetaRequest): Unit = {
+ val appId = pb.getAppId
+ logDebug(
+ s"Handling request for application meta info $appId.")
+ if (!secretRegistry.isRegistered(appId)) {
+ logWarning(s"Could not find the application meta of $appId.")
+ context.sendFailure(new CelebornException(s"$appId is not registered."))
+ } else {
+ val pbApplicationMeta = PbApplicationMeta.newBuilder()
+ .setAppId(appId)
+ .setSecret(secretRegistry.getSecretKey(appId))
+ .build()
Review Comment:
Done
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -1099,6 +1103,26 @@ private[celeborn] class Master(
}.asJava
}
+ private def handleRequestForApplicationMeta(
+ context: RpcCallContext,
+ pb: PbApplicationMetaRequest): Unit = {
+ val appId = pb.getAppId
+ logDebug(
+ s"Handling request for application meta info $appId.")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
