waitinfuture commented on code in PR #2362:
URL:
https://github.com/apache/incubator-celeborn/pull/2362#discussion_r1518463596
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -422,11 +430,14 @@ private ByteBuf getNextChunk() throws IOException {
}
private PartitionReader createReader(
- PartitionLocation location, int fetchChunkRetryCnt, int
fetchChunkMaxRetry)
+ PartitionLocation location,
+ PbStreamHandler pbStreamHandler,
+ int fetchChunkRetryCnt,
+ int fetchChunkMaxRetry)
throws IOException, InterruptedException {
if (!location.hasPeer()) {
logger.debug("Partition {} has only one partition replica.", location);
- } else if (attemptNumber % 2 == 1) {
+ } else if (pbStreamHandler == null && attemptNumber % 2 == 1) {
Review Comment:
Should not change to peer is `pbStreamHandler` is not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
