waitinfuture commented on code in PR #2362:
URL:
https://github.com/apache/incubator-celeborn/pull/2362#discussion_r1537107068
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1699,16 +1699,25 @@ public CelebornInputStream readPartition(
int startMapIndex,
int endMapIndex,
ExceptionMaker exceptionMaker,
+ ArrayList<PartitionLocation> locations,
+ ArrayList<PbStreamHandler> streamHandlers,
+ int[] mapAttempts,
MetricsCallback metricsCallback)
throws IOException {
if (partitionId == Utils$.MODULE$.UNKNOWN_APP_SHUFFLE_ID()) {
logger.warn("Shuffle data is empty for shuffle {}:
UNKNOWN_APP_SHUFFLE_ID.", shuffleId);
return CelebornInputStream.empty();
}
- ReduceFileGroups fileGroups = updateFileGroup(shuffleId, partitionId);
- if (fileGroups.partitionGroups.isEmpty()
- || !fileGroups.partitionGroups.containsKey(partitionId)) {
+ if (mapAttempts == null) {
+ ReduceFileGroups fileGroups = updateFileGroup(shuffleId, partitionId);
+ mapAttempts = fileGroups.mapAttempts;
Review Comment:
That's because `locations` can be empty even though BatchOpenStream has been
tried. If `mapAttempts` is null, it's guaranteed that BatchOpenStream has not
been tried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
