otterc commented on code in PR #2363:
URL:
https://github.com/apache/incubator-celeborn/pull/2363#discussion_r1518466706
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4632,4 +4634,12 @@ object CelebornConf extends Logging {
.version("0.5.0")
.intConf
.createWithDefault(8)
+
+ val WORKER_APPLICATION_REGISTRY_CACHE_SIZE: ConfigEntry[Int] =
+ buildConf("celeborn.worker.applicationRegistryCache.size")
+ .categories("worker", "auth")
+ .doc("Cache size of the application registry on Workers.")
+ .version("0.5.0")
+ .intConf
+ .createWithDefault(10000)
Review Comment:
workerInfo.getApplicationIdSet changes with new apps being added or removed.
I am not sure how we could configure the default value of this config to be the
size of that set. I did update the code to unregister an app from the worker's
secretRegistry from the cleaner thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
