waitinfuture commented on code in PR #2358:
URL:
https://github.com/apache/incubator-celeborn/pull/2358#discussion_r1522564208
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -211,7 +211,7 @@ private void fastWrite0(scala.collection.Iterator iterator)
throws IOException {
private void doPush() throws IOException {
long start = System.nanoTime();
- pusher.pushData();
+ pusher.pushData(false);
Review Comment:
I'm OK with not backporting to spark-2, we can revisit this in future if
it's required.
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -211,7 +211,7 @@ private void fastWrite0(scala.collection.Iterator iterator)
throws IOException {
private void doPush() throws IOException {
long start = System.nanoTime();
- pusher.pushData();
+ pusher.pushData(false);
Review Comment:
I'm OK not backporting to spark-2, we can revisit this in future if it's
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
