waitinfuture commented on code in PR #2358:
URL:
https://github.com/apache/incubator-celeborn/pull/2358#discussion_r1522614356
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedPusher.java:
##########
@@ -44,6 +44,61 @@
public class SortBasedPusher extends MemoryConsumer {
+ class MemoryThresholdManager {
+
+ private final long maxMemoryThresholdInBytes;
+ private final double smallPushTolerateFactor;
+
+ MemoryThresholdManager(
+ int numPartitions, long sendBufferSizeInBytes, double
smallPushTolerateFactor) {
+ this.maxMemoryThresholdInBytes = numPartitions * sendBufferSizeInBytes;
Review Comment:
Hi @CodingCat , after rethinking, I think we still need a configuration to
limit the max memory threshold instead of calculating by `numPartitions *
sendBufferSizeInBytes`. Say we have 100,000 partition, and send buffer uses
default 64K, then threshold would be 6.4G, it's too large and not what we
wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
