turboFei commented on code in PR #2365:
URL:
https://github.com/apache/incubator-celeborn/pull/2365#discussion_r1531317165
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1142,12 +1141,26 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
authEnabled && internalPortEnabled
}
+ def appRegisterEnabled: Boolean = {
+ val appRegisterEnabled = get(APP_REGISTER_ENABLED) || authEnabled
+ val internalPortEnabled = get(INTERNAL_PORT_ENABLED)
Review Comment:
without internalPort, worker can not interactive with the master rpc
endpoint directly, as there is a RegisterationRpcHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
