RexXiong commented on code in PR #2365:
URL:
https://github.com/apache/incubator-celeborn/pull/2365#discussion_r1535251964
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -113,7 +113,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
private val mockDestroyFailure = conf.testMockDestroySlotsFailure
private val authEnabled = conf.authEnabledOnClient
- private var applicationMeta: ApplicationMeta = _
+ private var applicationAuthMeta: ApplicationMeta = _
Review Comment:
Keep the name as it not only for auth scenario
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -173,7 +173,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
if (authEnabled) {
logInfo(s"Authentication is enabled; setting up master and worker RPC
environments")
val appSecret = createSecret()
- applicationMeta = ApplicationMeta(appUniqueId, appSecret)
+ applicationAuthMeta = ApplicationMeta(appUniqueId, appSecret)
Review Comment:
Add else to initialize ApplicationMeta when auth disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
