mridulm commented on PR #2419: URL: https://github.com/apache/celeborn/pull/2419#issuecomment-2020651137
Note to reviewers, the ssl configs in this PR are namespaced differently from the current module configs. `celeborn.ssl.<module>` instead of the current `celeborn.<module>.ssl` for example. This was done primarily to indicate the inheritance relationship of `celeborn.ssl.rpc` (for ex) to `celeborn.ssl` configs. But I am not sure if this fits with the overall Celeborn configuration conventions or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
