mridulm commented on code in PR #2419:
URL: https://github.com/apache/celeborn/pull/2419#discussion_r1539434198
##########
common/src/main/scala/org/apache/celeborn/common/internal/config/ConfigEntry.scala:
##########
@@ -240,7 +240,7 @@ class OptionalConfigEntry[T](
prependedKey,
prependSeparator,
alternatives,
- s => Some(rawValueConverter(s)),
+ s => Option(rawValueConverter(s)),
Review Comment:
Allowing for the converter to return `null`, and so fallback to default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
