RexXiong commented on code in PR #2365:
URL: https://github.com/apache/celeborn/pull/2365#discussion_r1540531750
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -207,13 +209,20 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
private val changePartitionManager = new ChangePartitionManager(conf, this)
private val releasePartitionManager = new ReleasePartitionManager(conf, this)
+ private def updateApplicationMeta(): Unit = {
+
Utils.tryLogNonFatalError(masterClient.askSync[PbApplicationMetaUpdateResponse](
+ PbSerDeUtils.toPbApplicationMeta(applicationMeta),
+ classOf[PbApplicationMetaUpdateResponse]))
+ }
+
// Since method `onStart` is executed when `rpcEnv.setupEndpoint` is
executed, and
// `masterClient` is initialized after `rpcEnv` is initialized, if method
`onStart` contains
// a reference to `masterClient`, there may be cases where `masterClient` is
null when
// `masterClient` is called. Therefore, it's necessary to uniformly execute
the initialization
// method at the end of the construction of the class to perform the
initialization operations.
private def initialize(): Unit = {
// noinspection ConvertExpressionToSAM
+ updateApplicationMeta()
Review Comment:
> This actually conflicts with safely propagating the application secret to
the Celeborn Master. When auth is enabled, this will transmit application
secret to Celeborn Master without any Sasl client authentication. Currently, we
have added Anonymous client authentication, but the plan was to add other
mechanisms. cc. @mridulm
Based on my understanding, if authentication is enabled in Celeborn, it is
not possible to access the Celeborn Master without SASL client authentication.
This PR does not introduce new mechanisms; it merely adds an identifier to
ApplicationMeta. Therefore, I believe this PR does not compromise security.
@otterc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
