pan3793 commented on code in PR #2444:
URL: https://github.com/apache/celeborn/pull/2444#discussion_r1552642760
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4172,6 +4173,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val SPARK_SHUFFLE_FALLBACK_ENABLED: ConfigEntry[Boolean] =
Review Comment:
If we accept breaking change, how about
```
celeborn.client.spark.shuffle.fallback.policy=[ALWAYS|NEVER|CONDITIONAL]
celeborn.client.spark.shuffle.fallback.numPartitionsThreshold
```
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4172,6 +4173,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val SPARK_SHUFFLE_FALLBACK_ENABLED: ConfigEntry[Boolean] =
Review Comment:
If we accept breaking change, how about
```
celeborn.client.spark.shuffle.fallback.policy=[ALWAYS|NEVER|AUTO]
celeborn.client.spark.shuffle.fallback.numPartitionsThreshold
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
