pan3793 commented on code in PR #2444:
URL: https://github.com/apache/celeborn/pull/2444#discussion_r1554810912
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4172,6 +4173,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val SPARK_SHUFFLE_FALLBACK_ENABLED: ConfigEntry[Boolean] =
Review Comment:
mark `celeborn.client.spark.shuffle.forceFallback.enabled` as deprecated,
but it should work until the next next release.
It says when `c.c.s.s.forceFallback.enabled=true`, log a deprecated warning
message, and mark `c.c.s.s.fallback.policy=ALWAYS`.
Other conditions like `c.c.s.s.forceFallback.numPartitionsThreshold` should
be renamed to `c.c.s.s.fallback.*`, and update docs to mention they only take
effects when `c.c.s.s.fallback.policy=AUTO`.
Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
