SteNicholas commented on code in PR #2442:
URL: https://github.com/apache/celeborn/pull/2442#discussion_r1554540932
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -79,6 +79,10 @@ private[celeborn] class Master(
private val authEnabled = conf.authEnabled
private val secretRegistry = new MasterSecretRegistryImpl()
+ if (conf.logMasterConfEnabled) {
+ logInfo(getConf)
Review Comment:
IMO, `getConf` returns all config options of master and worker. But this
should only log the master configs according to the name of
`celeborn.master.logConf`. Right?
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -86,6 +86,11 @@ private[celeborn] class Worker(
val workerStatusManager = new WorkerStatusManager(conf)
private val authEnabled = conf.authEnabled
private val secretRegistry = new
WorkerSecretRegistryImpl(conf.workerApplicationRegistryCacheSize)
+
+ if (conf.logWorkerConfEnabled) {
+ logInfo(getConf)
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
