FMX commented on code in PR #2442:
URL: https://github.com/apache/celeborn/pull/2442#discussion_r1554796260


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4923,4 +4927,20 @@ object CelebornConf extends Logging {
         s"Invalid maxEncryptedBlockSize, must be a position number upto 
${Int.MaxValue}")
       .createWithDefaultString("64k")
 
+  val LOG_MASTER_CONF: ConfigEntry[Boolean] =

Review Comment:
   The master and worker won't usually be on the same node, which means that a 
config could be enough for the master and worker components. These two configs 
can be merged as one. Maybe `celeborn.logConf` and print configs from the 
client could be OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to