RexXiong commented on code in PR #2449:
URL: https://github.com/apache/celeborn/pull/2449#discussion_r1555159963
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -415,29 +437,29 @@ protected void handleFailure(String errorMsg, Throwable
cause) {
private class PushChannelListener extends StdChannelListener {
final long pushRequestId;
- Runnable rpcSendOutCallback;
+ Runnable rpcFailureCallback;
PushChannelListener(long pushRequestId) {
this(pushRequestId, null);
}
- PushChannelListener(long pushRequestId, Runnable rpcSendOutCallback) {
+ PushChannelListener(long pushRequestId, Runnable rpcFailureCallback) {
super("PUSH " + pushRequestId);
this.pushRequestId = pushRequestId;
- this.rpcSendOutCallback = rpcSendOutCallback;
+ this.rpcFailureCallback = rpcFailureCallback;
}
@Override
public void operationComplete(Future<? super Void> future) throws
Exception {
super.operationComplete(future);
- if (rpcSendOutCallback != null) {
Review Comment:
IIRC this will affect buffer release from flink, IMO we can retain the
current setup and remove the rpcFailureCallback call from handleFailure, since
operationComplete will be invoked regardless of whether the channel fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
