FMX commented on code in PR #2449:
URL: https://github.com/apache/celeborn/pull/2449#discussion_r1555187698
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -225,14 +226,25 @@ public ChannelFuture pushData(
PushRequestInfo info = new PushRequestInfo(dueTime, callback);
handler.addPushRequest(requestId, info);
pushData.requestId = requestId;
- PushChannelListener listener = new PushChannelListener(requestId,
rpcSendoutCallback);
+ PushChannelListener listener =
+ new PushChannelListener(requestId, rpcSendoutCallback,
rpcFailureCallback);
ChannelFuture channelFuture =
channel.writeAndFlush(pushData).addListener(listener);
info.setChannelFuture(channelFuture);
return channelFuture;
}
public ChannelFuture pushMergedData(
PushMergedData pushMergedData, long pushDataTimeout, RpcResponseCallback
callback) {
+ return pushMergedData(
+ pushMergedData, pushDataTimeout, callback, null, () ->
pushMergedData.body().release());
Review Comment:
I think this could introduce IllegalReferenceCountException. Maybe here
needs more tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
