SteNicholas commented on code in PR #2475:
URL: https://github.com/apache/celeborn/pull/2475#discussion_r1575681673
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2917,12 +2917,12 @@ object CelebornConf extends Logging {
val WORKER_GRACEFUL_SHUTDOWN_RECOVER_DB_BACKEND: ConfigEntry[String] =
buildConf("celeborn.worker.graceful.shutdown.recoverDbBackend")
.categories("worker")
- .doc("Specifies a disk-based store used in local db. LEVELDB or
ROCKSDB.")
+ .doc("Specifies a disk-based store used in local db. ROCKSDB or LEVELDB
(deprecated).")
.version("0.4.0")
.stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValues(Set("LEVELDB", "ROCKSDB"))
- .createWithDefault("LEVELDB")
+ .createWithDefault("ROCKSDB")
Review Comment:
@mridulm, I have cherry pick #2369, #2372 to branch-0.4. The failure of CI
is caused by these pull request, not caused by the default value change.
BTW, @onebox-li, could you rebase branch-0.4 again? I have adjusted the
order of cherry pick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
