mridulm commented on code in PR #2475:
URL: https://github.com/apache/celeborn/pull/2475#discussion_r1575715563
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2917,12 +2917,12 @@ object CelebornConf extends Logging {
val WORKER_GRACEFUL_SHUTDOWN_RECOVER_DB_BACKEND: ConfigEntry[String] =
buildConf("celeborn.worker.graceful.shutdown.recoverDbBackend")
.categories("worker")
- .doc("Specifies a disk-based store used in local db. LEVELDB or
ROCKSDB.")
+ .doc("Specifies a disk-based store used in local db. ROCKSDB or LEVELDB
(deprecated).")
.version("0.4.0")
.stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValues(Set("LEVELDB", "ROCKSDB"))
- .createWithDefault("LEVELDB")
+ .createWithDefault("ROCKSDB")
Review Comment:
If 0.4 is not working on arm currently - wouldn't it not be better for arm
deployments to explicitly set it to ROCKSDB ? (in other words, not to change
the default ? ... or change default based on arch ? I dont think we do this
though ...)
To put it differently, my main concern is failure of existing deployments
... in our case, for example, we do not set this config (though we are still in
testing phase) - and we would typically expect a patch release to work
reasonably as is with existing config (between minor or major versions, there
will be a lot more scrutiny).
My 2 cents :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
