pan3793 commented on code in PR #2488:
URL: https://github.com/apache/celeborn/pull/2488#discussion_r1590546028


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4243,6 +4248,13 @@ object CelebornConf extends Logging {
         s"By default, the value is the max timeout value 
`${NETWORK_IO_CONNECTION_TIMEOUT.key}`.")
       .fallbackConf(NETWORK_IO_CONNECTION_TIMEOUT)
 
+  val CLIENT_RPC_COMMIT_FILES_RPC_ASK_TIMEOUT: ConfigEntry[Long] =
+    buildConf("celeborn.client.rpc.commitFiles.askTimeout")
+      .categories("client")
+      .version("0.5.0")
+      .doc("Timeout for CommitHandler commit files.")

Review Comment:
   mention the fallback logic in docs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to