SteNicholas commented on code in PR #2488:
URL: https://github.com/apache/celeborn/pull/2488#discussion_r1590619560
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4243,6 +4248,14 @@ object CelebornConf extends Logging {
s"By default, the value is the max timeout value
`${NETWORK_IO_CONNECTION_TIMEOUT.key}`.")
.fallbackConf(NETWORK_IO_CONNECTION_TIMEOUT)
+ val CLIENT_RPC_COMMIT_FILES_RPC_ASK_TIMEOUT: ConfigEntry[Long] =
Review Comment:
```suggestion
val CLIENT_RPC_COMMIT_FILES_ASK_TIMEOUT: ConfigEntry[Long] =
```
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -924,6 +924,11 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
get(CLIENT_RPC_GET_REDUCER_FILE_GROUP_RPC_ASK_TIMEOUT).milli,
CLIENT_RPC_GET_REDUCER_FILE_GROUP_RPC_ASK_TIMEOUT.key)
+ def clientRpcCommitFilesRpcAskTimeout: RpcTimeout =
Review Comment:
```suggestion
def clientRpcCommitFilesAskTimeout: RpcTimeout =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
